Skip to content

Change invocation step state display selector to fix styling#21144

Merged
mvdbeek merged 2 commits intogalaxyproject:devfrom
ahmedhamidawan:change_invocation_step_state_display_selector
Oct 23, 2025
Merged

Change invocation step state display selector to fix styling#21144
mvdbeek merged 2 commits intogalaxyproject:devfrom
ahmedhamidawan:change_invocation_step_state_display_selector

Conversation

@ahmedhamidawan
Copy link
Copy Markdown
Member

@ahmedhamidawan ahmedhamidawan commented Oct 23, 2025

We added a data-state selenium selector for the InvocationStepStateDisplay.vue component in #21058:

galaxy/client/src/components/WorkflowInvocationState/InvocationStepStateDisplay.vue

Lines 13 to 19 in be1ff8c

<template>
<span
class="d-flex align-items-center"
data-description="invocation step state counter"
:data-state="state"
:data-count="jobCount">
<FontAwesomeIcon

That unfortunately adds CSS styling from base.scss to the text in there:

image

This is the scss:

galaxy/client/src/style/scss/base.scss

Lines 158 to 163 in be1ff8c

@each $state in map-keys($galaxy-state-border) {
.state-color-#{$state},
[data-state="#{$state}"] {
border-color: map-get($galaxy-state-border, $state);
background-color: map-get($galaxy-state-bg, $state);

Therefore, I have changed the selector to data-step-state.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
Change invocation step state display selector to fix styling
1f7d837 
We added a `data-state` selenium selector for the `InvocationStepStateDisplay.vue` component in galaxyproject#21058.

That unfortunately adds CSS styling from `base.scss` to the text in there. Therefore, I have changed the selector to `data-step-state`.
@ahmedhamidawan ahmedhamidawan added this to the 26.0 milestone Oct 23, 2025
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review October 23, 2025 03:19
@mvdbeek mvdbeek merged commit 04c5c0b into galaxyproject:dev Oct 23, 2025
31 checks passed
@ahmedhamidawan ahmedhamidawan mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/UI-UX kind/bug

Projects

None yet

Milestone

26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedhamidawan @mvdbeek
⚡